Remove analytics from updater #48518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
reviewed
Mar 30, 2021
Comment on lines
+58
to
+65
| for option in (CONF_COMPONENT_REPORTING, CONF_REPORTING): | ||
| if option in conf: | ||
| _LOGGER.warning( | ||
| "Analytics reporting with the option '%s' " | ||
| "is deprecated and you should remove that from your configuration. " | ||
| "The analytics part of this integration has moved to the new 'analytics' integration", | ||
| option, | ||
| ) |
There was a problem hiding this comment.
Why not use cv.deprecated in the config schema?
There was a problem hiding this comment.
I want to mention the key, and does not care about it's value
There was a problem hiding this comment.
cv.deprecated mentions the key and doesn't care about it's value?
There was a problem hiding this comment.
Right... I was thinking of something else!
The response for cv.deprecated == I want to guide them to the analytics integration.
There was a problem hiding this comment.
Oh right, these users won't have the default_config 👍
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The
reportingandinclude_used_componentsconfiguration options have now been deprecated, theupdaterintegration will no longer report any analytics. The analytics has moved to it's own integration. See theanalyticsintegration for more details on how to configure it.Proposed change
reportingandinclude_used_componentsconfiguration options.https://updater.home-assistant.io/tohttps://www.home-assistant.io/version.jsonType of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: