8000 Update xknx to version 0.17.5 by marvin-w · Pull Request #48522 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update xknx to version 0.17.5 #48522

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2021
Merged

Update xknx to version 0.17.5 #48522

merged 2 commits into from
Mar 31, 2021

Conversation

marvin-w
Copy link
Contributor
@marvin-w marvin-w commented Mar 30, 2021 •
edited by frenck
Loading

Proposed change

This pull request adds support for opt-in unique ids for KNX entities. When users enable the use_unique_id feature the entities will have a unique id (based on the underlying device) attached to them.

XKNX/xknx@0.17.4...0.17.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@marvin-w marvin-w changed the title feat: Update xknx to version 0.17.5 Update xknx to version 0.17.5 Mar 30, 2021
@probot-home-assistant
Copy link

Hey there @Julius2342, @farmio, mind taking a look at this pull request as its been labeled with an integration (knx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@marvin-w marvin-w mentioned this pull request Mar 30, 2021
Closed
8 tasks
bdraco
bdraco reviewed Mar 31, 2021
View reviewed changes
frenck
frenck reviewed Mar 31, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes 😉

frenck
frenck reviewed Mar 31, 2021
View reviewed changes
@marvin-w @frenck
Apply suggestions from code review
126bcc7 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@marvin-w
Copy link
Contributor Author

Thanks @frenck. I applied all suggestions.

frenck
frenck approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marvin-w 👍

@frenck frenck merged commit 9e1a17c into home-assistant:dev Mar 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: knx new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marvin-w @frenck @bdraco @homeassistant
0