8000 Remove Social Blade integration (ADR-0004) by frenck · Pull Request #48677 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove Social Blade integration (ADR-0004) #48677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2021
Merged

Remove Social Blade integration (ADR-0004) #48677

merged 2 commits into from
Apr 4, 2021

Conversation

frenck
Copy link
Member
@frenck frenck commented Apr 4, 2021 •
edited
Loading

Breaking change

The Social Blade integration has been removed from Home Assistant because it relies on web scraping, which is no longer allowed.

Proposed change

While researching issue #48668, I've noticed the upstream package actually relies on web scraping:

https://github.com/meauxt/socialbladeclient/blob/531b29e2323c3dadc01c52e3df882a6c17630030/socialbladeclient/__init__.py#L7-L8

This violated ADR-0004: https://github.com/home-assistant/architecture/blob/master/adr/0004-webscraping.md

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

This was referenced Apr 4, 2021
Merged
Merged
@frenck frenck marked this pull request as ready for review April 4, 2021 15:25
davet2001
davet2001 approved these changes Apr 4, 2021
View reviewed changes
Copy link
Contributor
@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MartinHjelmare MartinHjelmare merged commit b34cc7e into dev Apr 4, 2021
@MartinHjelmare MartinHjelmare deleted the frenck-2021-1029 branch April 4, 2021 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@davet2001 davet2001 davet2001 approved these changes

Assignees
No one assigned
Labels
breaking-change cla-signed integration: socialblade remove-platform small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Social Blade integration broken in 2021.4 b Socialblade always gives error: Unable to find valid channel ID
4 participants
@frenck @MartinHjelmare @davet2001 @homeassistant
0