10000 Increase time out for http requests done in Axis integration by Kane610 · Pull Request #48610 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Increase time out for http re 8000 quests done in Axis integration #48610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2021
Merged

Increase time out for http requests done in Axis integration #48610

merged 2 commits into from
Apr 1, 2021

Conversation

Kane610
Copy link
Member
@Kane610 Kane610 commented Apr 1, 2021

Breaking change

Proposed change

Apparently the library is too aggressive to certain devices, typically on older firmware. The HTTPx library has a hidden 5 second time out per request, the library has increased this to 15 seconds. Integration default time out has been increased to 30 seconds.

Kane610/axis@v43...v44
There is new functionality introduced with v44, but it is not yet utilized so should be harmless.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2021.4.0 milestone Apr 1, 2021
@Kane610
Copy link
Member Author
Kane610 commented Apr 1, 2021

Thanks @MartinHjelmare 🎉

MartinHjelmare
MartinHjelmare reviewed Apr 1, 2021
View reviewed changes
@balloob balloob merged commit a61d93a into home-assistant:dev Apr 1, 2021
balloob pushed a commit that referenced this pull request Apr 1, 2021
@Kane610 @balloob
Increase time out for http requests done in Axis integration (#48610)
68b189c
@Kane610 Kane610 deleted the axis-improve_timeout_conditions branch April 1, 2021 23:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: axis small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.4.0
Development

Successfully merging this pull request may close these issues.

Axis integration broken
4 participants
@Kane610 @MartinHjelmare @balloob @homeassistant
0