Do not activate Met.no without setting a Home coordinates #48741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Danielhiversen, @thimic, mind taking a look at this pull request as its been labeled with an integration ( |
|
I think that is a frontend issue, we should not set some things somewhere. But I like the approach to abort it, should also work if we set 0.0 instead amsterdam |
|
I agree this is a frontend issue at some level, however, we currently have a lot of these instances out there. So this is more or less mitigating raised issues/concerns. Should I add |
balloob
approved these changes
Apr 6, 2021
|
Yes, let's also check on 0,0. |
balloob
reviewed
Apr 6, 2021
Danielhiversen
approved these changes
Apr 7, 2021
MartinHjelmare
requested changes
Apr 7, 2021
MartinHjelmare
approved these changes
Apr 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Based on issue #48730, we do a lot of traffic to the Met.no APIs/servers based on the default location. This happens when a user doesn't set a location explicitly during onboarding and causes the core configuration to default to the example data from the frontend:
const amsterdam = [52.3731339, 4.8903147];https://github.com/home-assistant/frontend/blob/109910d18f379e9a23cfc54f3f209e1d06042d72/src/onboarding/onboarding-core-config.ts#L29
Met.no is letting us know that we are in violation of their terms of services. This PR is to mitigate that. For more information see #48730.
Changes:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: