8000 Bump devolo Home Control to support old websocket-client versions again by Shutgun · Pull Request #48960 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump devolo Home Control to support old websocket-client versions again #48960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2021
Merged

Bump devolo Home Control to support old websocket-client versions again #48960

merged 1 commit into from
Apr 10, 2021

Conversation

Shutgun
Copy link
Contributor
@Shutgun Shutgun commented Apr 9, 2021 •
edited
Loading

Proposed change

We early moved to the recent version of websocket-client. However, that recent version has a breaking change and messes up more than it helps. So I worked on a way to support both for a while.

Changelog:
https://github.com/2Fake/devolo_home_control_api/releases/tag/v0.17.2
https://github.com/2Fake/devolo_home_control_api/releases/tag/v0.17.3

Commit compare:
2Fake/devolo_home_control_api@v0.17.1...v0.17.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @2Fake, mind taking a look at this pull request as its been labeled with an integration (devolo_home_control) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob added this to the 2021.4.3 milestone Apr 10, 2021
@balloob balloob merged commit 441c304 into home-assistant:dev Apr 10, 2021
balloob pushed a commit that referenced this pull request Apr 10, 2021
@Shutgun @balloob
Bump devolo Home Control to support old websocket-client versions aga…
995e22d 
…in (#48960)
@balloob balloob mentioned this pull request Apr 10, 2021
Merged
@Shutgun Shutgun deleted the support_old_websocket_client branch April 10, 2021 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency dependency-bump integration: devolo_home_control small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.4.3
Development

Successfully merging this pull request may close these issues.

devolo home inegration broken after upgrade to 2021.4
3 participants
@Shutgun @balloob @homeassistant
0