Fix Shelly button device triggers #48974 8000
Conversation
|
Hey there @balloob, @bieniu, @chemelli74, mind taking a look at this pull request as its been labeled with an integration ( |
| initialized=False, | ||
| ) | ||
|
|
||
| hass.data[DOMAIN] = {DATA_CONFIG_ENTRY: {}} |
There was a problem hiding this comment.
We don't want to interact with integration details in the tests. We should just set up the integration and patch in the periphery, eg the library, as needed.
https://developers.home-assistant.io/docs/development_testing#writing-tests-for-integrations
There was a problem hiding this comment.
This is not specific to this test, I am planning to rewrite all the tests, already tried some options but I was not happy with the result, If it is OK by you I would like to use your help for mocking the library in the right way.
There was a problem hiding this comment.
Looking at the library, one thing that makes the library harder to patch is that it is mixing the business logic of the Device class with the transport handling (aiohttp, coap and socket). If we'd break out the transport handling into a client class that the device can use, it would be easier to patch the client and know that all I/O is patched.
Proposed change
Shelly button is a sleeping device which it is not initialized after HA core restart until manually waked up by a button press.
When having device automations based input triggers for this device getting or validating the triggers will fail when device is not initialized.
Since this device has fixed input triggers it is not needed to wait for the device to wake up and input triggers types can be fixed.
Should be tagged for milestone 2021.4.3
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: