8000 Extend media source URL expiry to 24h by emontnemery · Pull Request #48912 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extend media source URL expiry to 24h #48912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

Extend media source URL expiry to 24h #48912

merged 1 commit into from
Apr 9, 2021

Conversation

emontnemery
Copy link
Contributor

Proposed change

Extend media source URL expiry from 30s to 24h

The 30s expiry time works if the media is continuously streamed using a single http session.
However, it won't work if the connection is broken for any reason during streaming (network issue, streaming is paused or skipped, etc.), thus extend it to a more liberal value.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2021.4.2 milestone Apr 9, 2021
@emontnemery emontnemery mentioned this pull request Apr 9, 2021
Closed
@probot-home-assistant
Copy link

Hey there @hunterjm, mind taking a look at this pull request as its been labeled with an integration (media_source) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Ph-Wagner Ph-Wagner mentioned this pull request Apr 9, 2021
Merged
21 tasks
@emontnemery emontnemery merged commit 346af58 into home-assistant:dev Apr 9, 2021
emontnemery added a commit that referenced this pull request Apr 9, 2021
@Ph-Wagner @emontnemery
Extend Google Cast media source URL expiry to 24h (#48937)
b66c4a9 
* Extend media source URL expiry to 12h

closes #46280
After checking out #48912 I just think why not.

* Update homeassistant/components/cast/media_player.py

Co-authored-by: Erik Montnemery <erik@montnemery.com>
balloob pushed a commit that referenced this pull request Apr 9, 2021
@emontnemery @balloob
Extend media source URL expiry to 24h (#48912)
1f21b19
balloob pushed a commit that referenced this pull request Apr 9, 2021
@Ph-Wagner @emontnemery @balloob
Extend Google Cast media source URL expiry to 24h (#48937)
4da77b9 
* Extend media source URL expiry to 12h

closes #46280
After checking out #48912 I just think why not.

* Update homeassistant/components/cast/media_player.py

Co-authored-by: Erik Montnemery <erik@montnemery.com>
@balloob balloob mentioned this pull request Apr 9, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@hunterjm hunterjm

Labels
bugfix cherry-picked cla-signed integration: media_source small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@emontnemery @MartinHjelmare @hunterjm @balloob @homeassistant
0