8000 Reinitialize upnp device on config change by StevenLooman · Pull Request #49081 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 Reinitialize upnp device on config change #49081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2021
Merged

Reinitialize upnp device on config change #49081

merged 5 commits into from
Apr 14, 2021

Conversation

StevenLooman
Copy link
Contributor
@StevenLooman StevenLooman commented Apr 11, 2021 •
edited
Loading

Proposed change

UPnP devices can send advertisements when their configuration has changed. async_upnp_client is extended with a helper to monitor these advertisements and, if the configuration or location is updated, the device is reinitialized.

A few devices change their address (specifically, TCP port) used serve clients, while this component previously only scanned for this address once during initialization and kept using that address. See #46822 for more information.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title upnp: On config change, reinitialize device Reinitialize upnp device on config change Apr 12, 2021
MartinHjelmare
MartinHjelmare requested changes Apr 12, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

MartinHjelmare
MartinHjelmare reviewed Apr 12, 2021
View reviewed changes
MartinHjelmare
MartinHjelmare approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 555f508 into home-assistant:dev Apr 14, 2021
@MartinHjelmare
Copy link
Member

Should we tag this for a patch release?

@StevenLooman
Copy link
Contributor Author

Thank you for merging!

I don't mind waiting for the next monthly release, as this means there is a longer testing period, right? Now that hass analytics shows me how 'popular' upnp is... :) I don't expect anything to break, just want to be on the safe side.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2021
@StevenLooman StevenLooman deleted the fix_46822_follow_device_updates branch May 9, 2021 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed integration: upnp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asus Rotuer Upnp integration
3 participants
@StevenLooman @MartinHjelmare @homeassistant
0