Add targets and selectors for services (S-T) #50629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
approved these changes
May 15, 2021
frenck
reviewed
May 15, 2021
Comment on lines
+64
to
+68
| options: | ||
| - 'low' | ||
| - 'medium' | ||
| - 'high' | ||
| - 'off' |
Comment on lines
+75
to
+79
| options: | ||
| - 'low' | ||
| - 'medium' | ||
| - 'high' | ||
| - 'off' |
Comment on lines
+124
to
+128
| options: | ||
| - 'low' | ||
| - 'medium' | ||
| - 'high' | ||
| - 'off' |
There was a problem hiding this comment.
Voice prompt volume is an integer
Comment on lines
14
to
+21
| entity_id: | ||
| description: Entity ID of the players to join to the "master". | ||
| example: "media_player.bedroom" | ||
| name: Entity | ||
| description: The players to join to the "master". | ||
| selector: | ||
| target: | ||
| entity: | ||
| integration: snapcast | ||
| domain: media_player |
There was a problem hiding this comment.
snapcast.join is an entity service, it should be migrated to a target instead.
Comment on lines
+30
to
+34
| selector: | ||
| target: | ||
| entity: | ||
| integration: soundtouch | ||
| domain: media_player |
There was a problem hiding this comment.
This accepts multiple entity IDs. We should be using the object selector instead.
Comment on lines
+53
to
+56
| target: | ||
| entity: | ||
| integration: soundtouch | ||
| domain: media_player |
There was a problem hiding this comment.
This accepts multiple entity IDs. We should be using the object selector instead.
Comment on lines
+74
to
+78
| selector: | ||
| target: | ||
| entity: | ||
| integration: soundtouch | ||
| domain: media_player |
There was a problem hiding this comment.
This accepts multiple entity IDs. We should be using the object selector instead.
| example: Errands | ||
| default: Inbox |
There was a problem hiding this comment.
Not sure if this is case sensitive, but the default is inbox.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add targets and selectors for services (S-T)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: