8000 Fix Tibber timestamps parsing by Danielhiversen · Pull Request #51368 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Tibber timestamps parsing #51368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2021
Merged

Fix Tibber timestamps parsing #51368

merged 2 commits into from
Jun 2, 2021

Conversation

Danielhiversen
Copy link
Member

Signed-off-by: Daniel Hjelseth Høyer github@dahoiv.net

Breaking change

Proposed change

Tibber, Fix parsing timestamps, fixes #51275
Temporary workaround until the Tibber API is fixed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Danielhiversen
Tibber, Fix parsing timestamps, fixed #51275
0dc9845 
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@Danielhiversen Danielhiversen added this to the 2021.6.0 milestone Jun 2, 2021
@MartinHjelmare MartinHjelmare changed the title Tibber, Fix parsing timestamps, fixes #51275 Fix Tibber timestamps parsing Jun 2, 2021
@Danielhiversen
use dt_util.parse_datetime
5a2218e 
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
balloob
balloob approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member
@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not just a temporary fix, that's the correct fix :)

@balloob balloob merged commit 31bd415 into dev Jun 2, 2021
@balloob balloob deleted the tibber_ts_fix branch June 2, 2021 15:16
frenck pushed a commit that referenced this pull request Jun 2, 2021
@Danielhiversen @frenck
Fix Tibber timestamps parsing (#51368)
7938f69
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: tibber small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.6.0
Development

Successfully merging this pull request may close these issues.

Tibber broken in current beta
5 participants
@Danielhiversen @balloob @MartinHjelmare @frenck @homeassistant
0