8000 Fix SIA event data func by eavanvalkenburg · Pull Request #51339 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix SIA event data func #51339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2021
Merged

Fix SIA event data func #51339

merged 1 commit into from
Jun 1, 2021

Conversation

eavanvalkenburg
Copy link
Contributor

Breaking change

None

Proposed change

I noticed a small mistake in the event data function.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@eavanvalkenburg
Copy link
Contributor Author

@MartinHjelmare @frenck if possible please include in 2021.6, noticed this while testing the next PR's!

@frenck frenck changed the title fix event data func SIA: fix event data func Jun 1, 2021
@frenck frenck added this to the 2021.6.0 milestone Jun 1, 2021
MartinHjelmare
MartinHjelmare approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title SIA: fix event data func Fix SIA event data func Jun 1, 2021
@MartinHjelmare MartinHjelmare merged commit e5dff49 into home-assistant:dev Jun 1, 2021
balloob pushed a commit that referenced this pull request Jun 1, 2021
@eavanvalkenburg @balloob
Fix SIA event data func (#51339)
464c66f
@eavanvalkenburg eavanvalkenburg deleted the sia_fix branch June 2, 2021 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: sia small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@eavanvalkenburg @frenck @MartinHjelmare @balloob @homeassistant
0