8000 Ensure host is always set with samsungtv SSDP discovery by bdraco · Pull Request #51527 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure host is always set with samsungtv SS 8000 DP discovery #51527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2021
Merged

Ensure host is always set with samsungtv SSDP discovery #51527

merged 1 commit into from
Jun 5, 2021

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Jun 5, 2021 •
edited
Loading

Proposed change

There was a case where self._host could have been None
before _async_set_unique_id_from_udn was called

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Ensure host is always set with samsungtv SSDP discovery
5164405 
There was a case where self._host could have been None
before _async_set_unique_id_from_udn was called

Fixes home-assistant#51186
@probot-home-assistant probot-home-assistant bot added integration: samsungtv small-pr PRs with less than 30 lines. labels Jun 5, 2021
@bdraco bdraco added this to the 2021.6.3 milestone Jun 5, 2021
@probot-home-assistant
Copy link

Hey there @escoand, @chemelli74, mind taking a look at this pull request as its been labeled with an integration (samsungtv) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

MartinHjelmare
MartinHjelmare approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 8c00c24 into home-assistant:dev Jun 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@chemelli74 chemelli74

Labels
cherry-picked cla-signed integration: samsungtv small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.6.3
Development

Successfully merging this pull request may close these issues.

Samsung TV integration fails intermittently on 2021.6 samsungtv integration not working anymore on 2021.6.0b0
5 participants
@bdraco @MartinHjelmare @balloob @homeassistant @chemelli74
0