8000 Improve type hints in stream by uvjustin · Pull Request #51837 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve type hints in stream #51837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 14, 2021
Merged

Improve type hints in stream #51837

merged 10 commits into from
Jun 14, 2021

Conversation

uvjustin
Copy link
Contributor
@uvjustin uvjustin commented Jun 14, 2021 •
edited by KapJI
Loading

Proposed change

#49608 implements LL-HLS in stream, but that PR is too large, making it hard to review. This an intermediate PR which updates the type hints in the stream component.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @hunterjm, @allenporter, mind taking a look at this pull request as its been labeled with an integration (stream) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

KapJI
KapJI approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member
@KapJI KapJI left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Please also consider enabling strict checks by adding stream to .strict-typing.

uvjustin added 4 commits June 14, 2021 11:49
@uvjustin
Fix import locations
1af602d 
Add dict type parameters
@uvjustin
Add stream to .strict-typing
dff3815
@uvjustin
Update mypy.ini
e87c43f
@uvjustin
Add missing type hints
f5e0758 
Fix strict errors
Use Any for av.audio.AudioStream
Ignore unreachable errors
uvjustin
uvjustin commented Jun 14, 2021
View reviewed changes
uvjustin
uvjustin commented Jun 14, 2021
View reviewed changes
uvjustin
uvjustin commented Jun 14, 2021
View reviewed changes
@uvjustin
Copy link
Contributor Author

@KapJI Had to make a few changes to pass strict checking. Can you take another look?

KapJI
KapJI requested changes Jun 14, 2021
View reviewed changes
uvjustin and others added 5 commits June 14, 2021 22:30
@uvjustin @KapJI
Use type hinted variable instead of cast
40f87ca 
Co-authored-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
@uvjustin @KapJI
Remove #type:ignore
140d852 
Co-authored-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
@uvjustin
Add type hint to first_packet
090a4bd
@uvjustin
Use None as unused parameter type
a7d024d
@uvjustin
Use datetime for _now type
f7026a8
KapJI
KapJI approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member
@KapJI KapJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@uvjustin
Copy link
Contributor Author

Thanks @KapJI

@uvjustin uvjustin merged commit 97e77ab into home-assistant:dev Jun 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KapJI KapJI KapJI approved these changes

Assignees

@hunterjm hunterjm

@KapJI KapJI

@allenporter allenporter

Labels
by-code-owner cla-signed code-quality core has-tests integration: stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uvjustin @KapJI @hunterjm @allenporter @homeassistant
0