8000 Warn if `interface_addr` remains in Sonos configuration by jjlawren · Pull Request #52652 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Warn if interface_addr remains in Sonos configuration #52652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

Warn if interface_addr remains in Sonos configuration #52652

merged 1 commit into from
Jul 8, 2021

Conversation

jjlawren
Copy link
Contributor
@jjlawren jjlawren commented Jul 7, 2021 •
edited
Loading

Breaking change

The interface_addr config option for Sonos is deprecated and unused. This functionality has been moved to the Network integration.

Proposed change

Warn users if interface_addr still exists in their configuration and how to correct it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as its been labeled with an integration (sonos) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@jjlawren jjlawren added this to the 2021.7.1 milestone Jul 7, 2021
@jjlawren jjlawren mentioned this pull request Jul 7, 2021
Merged
8 tasks
frenck
frenck approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jjlawren 👍

@frenck frenck merged commit dabb50f into home-assistant:dev Jul 8, 2021
tkdrob pushed a commit to tkdrob/core that referenced this pull request Jul 8, 2021
@jjlawren @tkdrob
Warn if interface_addr remains in Sonos configuration (home-assista…
5048516 
…nt#52652)
frenck pushed a commit that referenced this pull request Jul 8, 2021
@jjlawren @frenck
Warn if interface_addr remains in Sonos configuration (#52652)
b9827a5
@frenck frenck mentioned this pull request Jul 8, 2021
Merged
sjiampojamarn pushed a commit to sjiampojamarn/core that referenced this pull request Jul 8, 2021
@jjlawren @sjiampojamarn
Warn if interface_addr remains in Sonos configuration (home-assista…
956ba43 
…nt#52652)
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2021
@jjlawren jjlawren deleted the sonos_warn_discovery_ip_deprecation branch May 31, 2022 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@bdraco bdraco bdraco approved these changes

Assignees

@cgtobi cgtobi

Labels
bugfix by-code-owner cherry-picked cla-signed integration: sonos small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.7.1
Development

Successfully merging this pull request may close these issues.

Sonos Speakers are not detected in 2021.7.0
5 participants
@jjlawren @frenck @bdraco @cgtobi @homeassistant
0