8000 Add missing `motor_speed` sensor for Xiaomi Miio humidifier CA1 and CB1 by bieniu · Pull Request #54202 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing motor_speed sensor for Xiaomi Miio humidifier CA1 and CB1 #54202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2021
Merged

Add missing motor_speed sensor for Xiaomi Miio humidifier CA1 and CB1 #54202

merged 1 commit into from
Aug 8, 2021

Conversation

bieniu
Copy link
Member
@bieniu bieniu commented Aug 7, 2021

Breaking change

Proposed change

During the humidifier rework we missed that zhimi.humidifier.ca1 and zhimi.humidifier.cb1 support the motor speed sensor. This PR adds this sensor for those humidifiers.

The dev branch is newer than rc so I'll open a separate PR to fix this in dev branch.

CC: @jbouwh

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bieniu bieniu added this to the 2021.8.4 milestone Aug 7, 2021
@bieniu bieniu requested review from rytilahti and syssi as code owners August 7, 2021 09:29
@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

MartinHjelmare
MartinHjelmare approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Member

Note that this PR is targeting rc branch. We should add the label cherry-picked after merging it.

@pieonboard
Copy link
Contributor

Hi @bieniu
Thanks for this change. May I ask you to add depth sensor also in addition to motor_speed? Or I can do that after your change.

@bieniu
Copy link
Member Author
bieniu commented Aug 7, 2021

@MartinHjelmare The dev branch is newer than rc, so I was targeting rc. I'll open new PR to fix this in dev.

@bieniu
Copy link
Member Author
bieniu commented Aug 7, 2021

@SmaginPV Please read this #54153 (comment)

jbouwh
jbouwh approved these changes Aug 7, 2021
View reviewed changes
Copy link
Contributor
@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. and works with the MIOT humidifiers.

@jbouwh
Copy link
Contributor
jbouwh commented Aug 7, 2021

@MartinHjelmare The dev branch is newer than rc, so I was targeting rc. I'll open new PR to fix this in dev.

@bieniu You could retarget this PR against dev as well.

@MartinHjelmare
Copy link
Member

It's correct to target rc of there would be a merge conflict to cherry-pick from dev to rc.

To not include PRs that are already merged to rc in the cherry-pick script run we add the label cherry-picked.

@balloob balloob merged commit 4fbe713 into home-assistant:rc Aug 8, 2021
@balloob balloob mentioned this pull request Aug 8, 2021
Merged
@bieniu bieniu deleted the humidifier-ca1-cb1 branch August 8, 2021 05:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@jbouwh jbouwh jbouwh approved these changes

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti is a code owner

@syssi syssi Awaiting requested review from syssi syssi is a code owner

Assignees
No one assigned
Labels
cherry-picked cla-signed
Projects
None yet
Milestone
2021.8.4
Development

Successfully merging this pull request may close these issues.
6 participants
@bieniu @MartinHjelmare @pieonboard @jbouwh @balloob @homeassistant
0