8000 Re-add Tibber notify service name by Danielhiversen · Pull Request #54401 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Re-add Tibber notify service name #54401

< 8000 /div>
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2021
Merged

Re-add Tibber notify service name #54401

merged 1 commit into from
Aug 10, 2021

Conversation

Danielhiversen
Copy link
Member

Signed-off-by: Daniel Hjelseth Høyer github@dahoiv.net

Breaking change

Proposed change

Tibber notify
Revert unintended change: https://github.com/home-assistant/core/pull/53235/files#r684804529

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Danielhiversen
Tibber notify
5ebf93f 
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@MartinHjelmare MartinHjelmare changed the title Tibber notify Re-add Tibber notify service name Aug 10, 2021
MartinHjelmare
MartinHjelmare approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit ba6bdff into dev Aug 10, 2021
@MartinHjelmare MartinHjelmare deleted the tibber_notify branch August 10, 2021 18:14
@MartinHjelmare MartinHjelmare added this to the 2021.8.6 milestone Aug 10, 2021
balloob pushed a commit that referenced this pull request Aug 11, 2021
@Danielhiversen @balloob
Re-add Tibber notify service name (#54401)
56d5140 
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
@balloob balloob mentioned this pull request Aug 11, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@ludeeus ludeeus ludeeus approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: tibber small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.8.6
Development

Successfully merging this pull request may close these issues.
5 participants
@Danielhiversen @MartinHjelmare @ludeeus @balloob @homeassistant
2A6C
0