8000 Upgrade aiomusiccast to tolererate not decodable characters by micha91 · Pull Request #57461 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade aiomusiccast to tolererate not decodable characters #57461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

Upgrade aiomusiccast to tolererate not decodable characters #57461

merged 1 commit into from
Oct 11, 2021

Conversation

micha91
Copy link
Contributor
@micha91 micha91 commented Oct 11, 2021

Proposed change

It seems like Yamaha MusicCast devices return tuner station names in exactly the way, the device receives them from the station. Due to that it is possible that there are characters received, which are not decodable. The new version of aiomusiccast will tolerate these characters and logs a warning, if there were non decodable characters in a response of a MusicCast device. The changes in the new release of aiomusiccast are documented here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @vigonotion, mind taking a look at this pull request as it has been labeled with an integration (yamaha_musiccast) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 11, 2021
@frenck frenck added this to the 2021.10.4 milestone Oct 11, 2021
frenck
frenck approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @micha91 👍

Happy Hacktoberfest 🎉

../Frenck

@frenck frenck merged commit 20d08fa into home-assistant:dev Oct 11, 2021
@adorobis
Copy link

Thanks @micha91 for super fast fixing of the issue!

balloob pushed a commit that referenced this pull request Oct 12, 2021
@micha91 @balloob
Upgrade aiomusiccast to tolererate not decodable characters (#57461)
60d9bc6
@balloob balloob mentioned this pull request Oct 12, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@vigonotion vigonotion vigonotion approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency dependency-bump Hacktoberfest integration: yamaha_musiccast small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2021.10.4
Development

Successfully merging this pull request may close these issues.

Can't add one of the music cast devices to HA
6 participants
@micha91 @adorobis @frenck @vigonotion @balloob @homeassistant
0