8000 Avoid setting up harmony websocket from discovery by bdraco · Pull Request #57589 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid setting up harmony websocket from discovery #57589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 18, 2021
Merged

Avoid setting up harmony websocket from discovery #57589

merged 14 commits into from
Oct 18, 2021

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Oct 13, 2021 •
edited
Loading

Proposed change

Probing for the remote id would connect the websocket which could overload the device if there were too many re-discoveries.

Fixes #57542

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @ehendrix23, @bramkragten, @mkeesey, @Aohzan, mind taking a look at this pull request as it has been labeled with an integration (harmony) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco mentioned this pull request Oct 13, 2021
Closed
@bdraco bdraco mentioned this pull request Oct 16, 2021
Merged
@bdraco bdraco added the waiting-for-upstream We're waiting for a change upstream label Oct 16, 2021
bdraco
bdraco commented Oct 16, 2021
View reviewed changes
bdraco
bdraco commented Oct 16, 2021
View reviewed changes
@bdraco
Copy link
Member Author
bdraco commented Oct 16, 2021

The ConfigEntryNotReady would have a reason of None so I tweaked that as well so its a lot easier to tell what has gone wrong

Screen Shot 2021-10-15 at 8 46 34 PM

bdraco
bdraco commented Oct 16, 2021
View reviewed changes
bdraco
bdraco commented Oct 16, 2021
View reviewed changes
bdraco
bdraco commented Oct 16, 2021
View reviewed changes
@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label Oct 17, 2021
@bdraco bdraco added this to the 2021.10.6 milestone Oct 17, 2021
@bdraco bdraco marked this pull request as ready for review October 17, 2021 17:16
@bdraco bdraco requested a review from bramkragten as a code owner October 17, 2021 17:16
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 17, 2021
@balloob balloob merged commit cac0c04 into home-assistant:dev Oct 18, 2021
balloob pushed a commit that referenced this pull request Oct 18, 2021
@bdraco @balloob
Avoid setting up harmony websocket from discovery (#57589)
010daaf
This was referenced Oct 18, 2021
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@bramkragten bramkragten Awaiting requested review from bramkragten

Assignees

@bramkragten bramkragten

Labels
by-code-owner cherry-picked cla-signed Hacktoberfest has-tests integration: harmony small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2021.10.6
Development

Successfully merging this pull request may close these issues.

Logitech Harmony integration stopped working
5 participants
@bdraco @balloob @frenck @bramkragten @homeassistant
0