8000 Log reason for DLNA-DMR device becoming unavailable by chishm · Pull Request #57516 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Log reason for DLNA-DMR device becoming unavailable #57516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2021
Merged

Log reason for DLNA-DMR device becoming unavailable #57516

merged 1 commit into from
Oct 15, 2021

Conversation

chishm
Copy link
Contributor
@chishm chishm commented Oct 12, 2021 •
edited
Loading

Proposed change

When a DLNA-DMR device is disconnected due to a UpnpError, log this to the debug log. This is to help diagnose the problem in #57240.

When this is accepted, can it please be cherry-picked into release 2010.10 too?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@chishm chishm requested a review from StevenLooman as a code owner October 12, 2021 05:28
@probot-home-assistant
Copy link

Hey there @StevenLooman, mind taking a look at this pull request as it has been labeled with an integration (dlna_dmr) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

balloob
balloob reviewed Oct 12, 2021
View reviewed changes
homeassistant/components/dlna_dmr/media_player.py
except UpnpError:
_LOGGER.debug("Device unavailable")
except UpnpError as err:
_LOGGER.debug("Device unavailable: %r", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not %s?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%r will print the error class as well as the error message, which allows distinguishing subtypes of UpnpError. They don't all have an error message, which is what %s would print.

@chishm chishm mentioned this pull request Oct 14, 2021
Merged
22 tasks
@rytilahti rytilahti added this to the 2021.10.5 milestone Oct 15, 2021
rytilahti
rytilahti approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member
@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear yet simple improvement for anyone debugging these devices, so let's get it merged!

@rytilahti rytilahti merged commit aeb0082 into home-assistant:dev Oct 15, 2021
balloob pushed a commit that referenced this pull request Oct 15, 2021
@chishm @balloob
Log reason for DLNA-DMR device becoming unavailable (#57516)
6193b31
@balloob balloob mentioned this pull request Oct 15, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2021
@chishm chishm deleted the dlna_dmr-disconnect-reason branch October 31, 2021 01:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob left review comments

@rytilahti rytilahti rytilahti approved these changes

@StevenLooman StevenLooman Awaiting requested review from StevenLooman

Assignees

@StevenLooman StevenLooman

Labels
bugfix by-code-owner cherry-picked cla-signed Hacktoberfest integration: dlna_dmr small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.10.5
Development

Successfully merging this pull request may close these issues.
5 participants
@chishm @balloob @rytilahti @StevenLooman @homeassistant
0