8000 Ensure Notion device name is stored as a string by bachya · Pull Request #57670 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure Notion device name is stored as a string #57670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

Ensure Notion device name is stored as a string #57670

merged 1 commit into from
Oct 14, 2021

Conversation

bachya
Copy link
Contributor
@bachya bachya commented Oct 14, 2021 •
edited
Loading

Proposed change

Notion was storing its device name as an int, which breaks HomeKit.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya added this to the 2021.10.5 milestone Oct 14, 2021
@bachya bachya self-assigned this Oct 14, 2021
@balloob balloob merged commit 681b5c4 into home-assistant:dev Oct 14, 2021
janiversen pushed a commit to janiversen/core that referenced this pull request Oct 15, 2021
@bachya @janiversen
Ensure Notion device name is stored as a string (home-assistant#57670)
874f020
balloob pushed a commit that referenced this pull request Oct 15, 2021
@bachya @balloob
Ensure Notion device name is stored as a string (#57670)
3d1cbe4
@balloob balloob mentioned this pull request Oct 15, 2021
Merged
@bachya bachya deleted the fix-57608 branch October 15, 2021 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees

@bachya bachya

Labels
bugfix by-code-owner cherry-picked cla-signed Hacktoberfest integration: notion small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.10.5
Development

Successfully merging this pull request may close these issues.

Notion integration stores a device name as an int instead of a str
3 participants
@bachya @balloob @homeassistant
0