8000 Fix bug that prevents multiple instances of Tile by bachya · Pull Request #57942 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix bug that prevents multiple instances of Tile 8000 #57942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2021
Merged

Fix bug that prevents multiple instances of Tile #57942

merged 2 commits into from
Oct 18, 2021

Conversation

bachya
Copy link
Contributor
@bachya bachya commented Oct 18, 2021

Proposed change

#57912 revealed that Tile's API stores cookies that identify the API consumer; by using the same aiohttp ClientSession, users could not implement multiple config entries. This PR fixes things by creating a ClientSession for each entry. It also includes a small pytile bump.

Changelog: https://github.com/bachya/pytile/releases/tag/5.2.4
Diff: bachya/pytile@5.2.3...5.2.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya added this to the 2021.10.6 milestone Oct 18, 2021
@bachya bachya self-assigned this Oct 18, 2021
bdraco
bdraco approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@balloob balloob merged commit 6a8ff9f into home-assistant:dev Oct 18, 2021
balloob pushed a commit that referenced this pull request Oct 18, 2021
@bachya @balloob
Fix bug that prevents multiple instances of Tile (#57942)
b5f2bff
This was referenced Oct 18, 2021
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
@bachya bachya deleted the tile-session branch October 19, 2021 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

@bachya bachya

Labels
bugfix by-code-owner cherry-picked cla-signed Hacktoberfest integration: tile small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.10.6
Development

Successfully merging this pull request may close these issues.

All Tile entities become unavailable when second tile account is being added
4 participants
@bachya @bdraco @balloob @homeassistant
0