8000 Revert "Fix check_control_message short description (#56876)" by cdce8p · Pull Request #57928 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert " 8000 Fix check_control_message short description (#56876)" #57928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2021
Merged

Revert "Fix check_control_message short description (#56876)" #57928

merged 1 commit into from
Oct 17, 2021

Conversation

cdce8p
Copy link
Member
@cdce8p cdce8p commented Oct 17, 2021

Proposed change

This reverts commit acda3af. (#56876)

Turns out the type comment in bimmer_connected was wrong.
For more details: #57880 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @gerard33, @rikroe, mind taking a look at this pull request as it has been labeled with an integration (bmw_connected_drive) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@cdce8p cdce8p added this to the 2021.10.6 milestone Oct 17, 2021
@cdce8p cdce8p force-pushed the fix_bmw_connected_drive branch from 6a4c5bc to 3690f81 Compare October 17, 2021 21:15
@cdce8p
Copy link
Member Author
cdce8p commented Oct 17, 2021

Will be replaced by a dependency bump once the upstream PR is merged.
bimmerconnected/bimmer_connected#319
#57880 (comment)

@cdce8p cdce8p closed this Oct 17, 2021
@cdce8p cdce8p deleted the fix_bmw_connected_drive branch October 17, 2021 21:33
@cdce8p cdce8p removed this from the 2021.10.6 milestone Oct 17, 2021
@cdce8p cdce8p restored the fix_bmw_connected_drive branch October 17, 2021 22:01
@cdce8p cdce8p reopened this Oct 17, 2021
@cdce8p cdce8p marked this pull request as draft October 17, 2021 22:02
@cdce8p cdce8p marked this pull request as ready for review October 17, 2021 22:05
@cdce8p cdce8p added this to the 2021.10.6 milestone Oct 17, 2021
@cdce8p
Copy link
Member Author
cdce8p commented Oct 17, 2021

Reopened PR as upstream needs more time. This will fix the issue in the mean time.

bdraco
bdraco approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdce8p cdce8p merged commit 3c4b715 into home-assistant:dev Oct 17, 2021
@cdce8p cdce8p deleted the fix_bmw_connected_drive branch October 17, 2021 23:21
balloob pushed a commit that referenced this pull request Oct 18, 2021
@cdce8p @balloob
Revert "Fix bmw_conntected_drive check_control_message short descript…
589db06 
…ion" (#57928)

This reverts commit acda3af.
This was referenced Oct 18, 2021
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed integration: bmw_connected_drive small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.10.6
Development

Successfully merging this pull request may close these issues.

BMW Connected Drive - AttributeError: 'dict' object has no attribute 'description_short'
4 participants
@cdce8p @bdraco @balloob @homeassistant
0