8000 Abort keenetic SSDP discovery if the unique id is already setup or ignored by foxel · Pull Request #58009 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Abo 8000 rt keenetic SSDP discovery if the unique id is already setup or ignored #58009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

Abort keenetic SSDP discovery if the unique id is already setup or ignored #58009

merged 1 commit into from
Oct 20, 2021

Conversation

foxel
Copy link
Contributor
@foxel foxel commented Oct 19, 2021 •
edited
Loading

Breaking change

Proposed change

This fixes ignoring SSDP discovered Keenetic router.

This also includes a change that will update host value if the router is rediscovered with a new host advertised

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@foxel foxel force-pushed the fix-58003 branch 3 times, most recently from 58c1cae to f2b2b97 Compare October 19, 2021 04:21
@foxel
Fix home-assistant#58003 - abort keenetic SSDP setup if ignored, upda…
6c3a067 
…te HOST if rediscovered already configured item
bdraco
bdraco approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bdraco bdraco changed the title Fix #58003 - abort keenetic SSDP setup if ignored Abort keenetic SSDP discovery if the unique id is already setup or ignored Oct 19, 2021
@bdraco bdraco added this to the 2021.10.7 milestone Oct 19, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 19, 2021
@balloob balloob merged commit a824fa9 into home-assistant:dev Oct 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
@foxel foxel deleted the fix-58003 branch October 25, 2021 03:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed Hacktoberfest integration: keenetic_ndms2 small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2021.10.7
Development

Successfully merging this pull request may close these issues.

Stop spam from Keenetic
5 participants
@foxel @bdraco @frenck @balloob @homeassistant
0