8000 Upgrade Tuya IoT Python SDK to 0.6.3 by frenck · Pull Request #58240 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade Tuya IoT Python SDK to 0.6.3 #58240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2021
Merged

Upgrade Tuya IoT Python SDK to 0.6.3 #58240

merged 2 commits into from
Oct 25, 2021

Conversation

frenck
Copy link
Member
@frenck frenck commented Oct 22, 2021 •
edited
Loading

Proposed change

Upgrades the Tuya IoT Python SDK to 0.6.3.

Release notes:

Compare: tuya/tuya-iot-python-sdk@v0.5.0...v0.6.3

Updated camera logic to use the library directly

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @tuya, @zlinoliver, @METISU, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck marked this pull request as draft October 22, 2021 18:38
@frenck
Copy link
Member Author
frenck commented Oct 22, 2021

Converting this PR to draft. Upstream has broken Python 3.8 compatibility.
I've reached out to see what is going on.

@zlinoliver
Copy link
Contributor

@frenck @MartinHjelmare , will release a new version (v0.6.3) of Tuya IoT Python SDK with Frenck's changes tomorrow, so this PR can be updated with that new version.

@frenck
Copy link
Member Author
frenck commented Oct 24, 2021

@zlinoliver Thanks! 👍

@zlinoliver
Copy link
Contributor

Hi @frenck the v0.6.3 is released, please help to update this PR to this version: https://github.com/tuya/tuya-iot-python-sdk/releases/tag/v0.6.3, thanks!

@frenck frenck changed the title Upgrade Tuya IoT Python SDK to 0.6.2 Upgrade Tuya IoT Python SDK to 0.6.3 Oct 25, 2021
@frenck frenck marked this pull request as ready for review October 25, 2021 06:48
@frenck
Copy link
Member Author
frenck commented Oct 25, 2021 •
edited
Loading

Bumped PR to 0.6.3, tested it locally, works as expected.
Rebased onto the latest dev and updated the PR description.

@MartinHjelmare
Copy link
Member
MartinHjelmare commented Oct 25, 2021 •
edited
Loading

The iot version is still 0.6.2. Does that matter?

https://github.com/tuya/tuya-iot-python-sdk/blob/209d1c7f30a718735acaca4f3b24537b6e34e24a/tuya_iot/version.py#L3

Looks like the package has the wrong version then.

@frenck
Copy link
Member Author
frenck commented Oct 25, 2021 •
edited
Loading

@MartinHjelmare It does matter, as it is used by the setup.py.

It seems like they published something else than the repo:

image

So it doesn't matter for this change. All other files seem to be the same as the repo.

@frenck frenck merged commit 21709e7 into dev Oct 25, 2021
@frenck frenck deleted the frenck-2021-2635 branch October 25, 2021 10:09
@zlinoliver
Copy link
Contributor

The iot version is still 0.6.2. Does that matter?

https://github.com/tuya/tuya-iot-python-sdk/blob/209d1c7f30a718735acaca4f3b24537b6e34e24a/tuya_iot/version.py#L3

Looks like the package has the wrong version then.

Sorry, the version is updated to 0.6.3.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed dependency Hacktoberfest integration: tuya small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frenck @zlinoliver @MartinHjelmare @homeassistant
0