Run nuki bridge.info() on executor #58345
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it throws IO in main thread error without it
|
Hey there @pschmitt, @pvizeli, @pree, mind taking a look at this pull request as it has been labeled with an integration ( |
frenck
requested changes
Oct 24, 2021
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
Oct 25, 2021
| @@ -41,7 +41,7 @@ async def validate_input(hass, data): | |||
| DEFAULT_TIMEOUT, | |||
| ) | |||
|
|
|||
| info = bridge.info() | |||
| info = await hass.async_add_executor_job(bridge.info) | |||
There was a problem hiding this comment.
A future improvement is to create a function that does both sync calls, ie create the bridge and get the bridge info, and then schedule that function once on the executor. Switching context is expensive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it throws IO in main thread error without it
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: