-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Replace charging_time_remaining with charging_end_time in bmw_connected_drive #60942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MartinHjelmare
merged 8 commits into
home-assistant:dev
from
rikroe:mybmw-charing_end_time
Dec 22, 2021
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d12c224
Replace charging_time_remaining with charging_end_time
rikroe b9eb81c
Clean up, disable mybmw value by default
rikroe 51a29ec
Rename `charging_end_time_mybmw` to `_original`
rikroe 3e3828d
Update bimmer_connected to 0.8.6
rikroe 6150f2d
Use SensorDeviceClass for `charging_end_time`
rikroe 2d311b2
Rename `charging_end_time_original` to `charging_time_label`
rikroe ab71ae1
Add `charging_start_time` sensor
rikroe 34d27bf
Update bimmer_connected to 0.8.7
rikroe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to make sure, this returns a UTC datetime timestamp?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a tz-aware datetime object (https://github.com/bimmerconnected/bimmer_connected/blob/master/bimmer_connected/vehicle_status.py#L452) and displayed the correct time when testing.
EDIT: Nevermind, it is showing a value moved by one hour (CET timezone). I'll update to return UTC.
EDIT²: Nevermind², the tz-aware datetime values are parsed correctly and shown in the entity registry in UTC. If shown via lovelace they are converted to the correct timezone.