[recorder] Catch more startup errors #6179 #6192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proposal to replace this PR with #6196 |
983e76c to
e67bca3
Compare
|
Nice! 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.<
2E56
/span>
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I know generally general "Exceptions" are frowned upon, but there is no elegant way of finding all errors that could be thrown by this.
This specific Issue & thread here was because of
mysqlcleintnot being available, it generated an ImportErrorThe new behavior will retry for 100 seconds, then raise a persistent error. Meanwhile other tasks waiting on db_ready will timeout and raise an exception after 3xWait period - 15 seconds will be the new default from #6167
Related issue (if applicable): fixes #6179
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass