8000 Bump voluptuous_serialize to 2.5.0 by balloob · Pull Request #62363 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump voluptuous_serialize to 2.5.0 #62363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

balloob
Copy link
Member
@balloob balloob commented Dec 20, 2021

Breaking change

Proposed change

The binary sensor device class schema was changed in #60651 to use vol.Coerce(BinarySensorDeviceClass). Volutpuous serialize didn't support enum causing issues in config flow.

This PR bumps voluptuous serialize which adds support for enums: https://github.com/home-assistant-libs/voluptuous-serialize/releases/tag/2.5.0

Some issues occurred because the config flow tests didn't cover the use of the device class schema.

Fixes #62357
Fixes #61702

CC @frenck @epenet

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob added this to the 2021.12.4 milestone Dec 20, 2021
@balloob balloob requested a review from a team as a code owner December 20, 2021 05:43
@balloob balloob merged commit 02ad5f3 into dev Dec 20, 2021
@balloob balloob deleted the bump-voluptuous-serialize-2.5.0 branch December 20, 2021 06:28
balloob added a commit that referenced this pull request Dec 20, 2021
@balloob balloob mentioned this pull request Dec 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Konnected configuration flow errors when setting up BinarySensor(s)
3 participants
0