8000 Use new enums in vizio tests by davet2001 · Pull Request #62710 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use new enums in vizio tests #62710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 21, 2022
Merged

Use new enums in vizio tests #62710

merged 6 commits into from
Feb 21, 2022

Conversation

davet2001
Copy link
Contributor
@davet2001 davet2001 commented Dec 23, 2021 •
edited
Loading

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: Depends on Use enums in vizio #61996
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@davet2001 davet2001 requested a review from raman325 as a code owner December 23, 2021 22:08
@probot-home-assistant
Copy link

Hey there @raman325, mind taking a look at this pull request as it has been labeled with an integration (vizio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

epenet
epenet requested changes Dec 23, 2021
View reviewed changes
Copy link
Contributor
@epenet epenet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes to conftest, and mark this PR as draft until the corresponding core PR is merged. There are still some pending questions on the core PR. See #61996

@epenet epenet marked this pull request as draft December 23, 2021 22:11
@davet2001
Copy link
Contributor Author

@epenet Thanks for the review and the comments. Now sorted. I'll leave as draft unless you think it's ready to go ahead.

@davet2001 davet2001 marked this pull request as ready for review February 15, 2022 12:33
@davet2001
Copy link
Contributor Author
davet2001 commented Feb 15, 2022 •
edited
Loading

The core PR #61996 has been merged now so this should be ok to proceed.

epenet
epenet reviewed Feb 15, 2022
View reviewed changes
@epenet
Copy link
Contributor
epenet commented Feb 16, 2022

CI is failing at the moment

@davet2001
Copy link
Contributor Author
davet2001 commented Feb 16, 2022 •
edited
Loading

CI is failing at the moment

Yes, I noticed after it was too late to sort it out. Will have another look tonight... looks like I need to rebase.

@davet2001 davet2001 force-pushed the refactor_enum_vizio_tests branch from cc8fe95 to d286be2 Compare February 16, 2022 22:07
@davet2001
Copy link
Contributor Author

@epenet should be ok now

@frenck frenck requested a review from epenet February 18, 2022 08:42
epenet
epenet approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor
@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epenet epenet merged commit 8651597 into home-assistant:dev Feb 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epenet epenet epenet approved these changes

@raman325 raman325 Awaiting requested review from raman325 raman325 is a code owner

Assignees

@raman325 raman325

Labels
cla-signed code-quality has-tests integration: vizio small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davet2001 @epenet @raman325 @homeassistant
0