8000 Normalize Hue colortemp if value outside of bounds by marcelveldt · Pull Request #62998 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Normalize Hue colortemp if value outside of bounds #62998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 29, 2021
Merged

Normalize Hue colortemp if value outside of bounds #62998

merged 3 commits into from
Dec 29, 2021

Conversation

marcelveldt
Copy link
Member
@marcelveldt marcelveldt commented Dec 29, 2021 •
edited
Loading

Proposed change

Normalize color temperature to the upper/lower bounds Hue can handle.
The new API is a bit more fanatic with checking if the values are within the Hue range.

BTW: Why are these bounds not checked by the HA service call, is there a reason for that ?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@marcelveldt marcelveldt added this to the 2021.12.7 milestone Dec 29, 2021
@marcelveldt marcelveldt requested a review from balloob as a code owner December 29, 2021 13:54
@probot-home-assistant
Copy link

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck
Copy link
Member
frenck commented Dec 29, 2021

BTW: Why are these bounds not checked by the HA service call, is there a reason for that ?

🤷 That can be added. It is kinda recent we started adding checks for these things (for example, if the passed option for a select entity is actually valid or not).

@marcelveldt
Copy link
Member Author

🤷 That can be added. It is kinda recent we started adding checks for these things (for example, if the passed option for a select entity is actually valid or not).

Thanks, makes sense to add it then but not in a bugfix release. Don't know if the min/max values are reliable for all integrations.

@frenck
Copy link
Member
frenck commented Dec 29, 2021

Thanks, makes sense to add it then but not in a bugfix release. Don't know if the min/max values are reliable for all integrations.

Agreed.

@frenck frenck merged commit 497bfc1 into home-assistant:dev Dec 29, 2021
frenck pushed a commit that referenced this pull request Dec 29, 2021
@marcelveldt @frenck
Normalize Hue colortemp if value outside of bounds (#62998)
70c16d4
@frenck frenck mentioned this pull request Dec 29, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@balloob balloob Awaiting requested review from balloob balloob is a code owner

Assignees

@balloob balloob

Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: hue small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.7
Development

Successfully merging this pull request may close these issues.

Flux in mired mode not working with Philips Hue in 2021.12
0