8000 Remove `setup.py` by cdce8p · Pull Request #66023 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove setup.py #66023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2022
Merged

Remove setup.py #66023

merged 2 commits into from
Feb 21, 2022

Conversation

cdce8p
Copy link
Member
@cdce8p cdce8p commented Feb 7, 2022 •
edited
Loading

Proposed change

With the update to pip>=21.0, it's no longer needed for editable installs.
https://pip.pypa.io/en/stable/news/#id50
Ref: #59769

PR for frontend: home-assistant/frontend#11593

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cdce8p
Remove setup.py
d58cbb2 
* With the update to pip>=21.0, it's no longer needed for editable installs
@cdce8p cdce8p requested a review from a team as a code owner February 7, 2022 16:00
@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Feb 7, 2022
@cdce8p cdce8p mentioned this pull request Feb 7, 2022
Merged
9 tasks
@frenck
Copy link
Member
frenck commented Feb 7, 2022

Let's not until we have at least 1 successful night build without issues.

ludeeus
ludeeus previously requested changes Feb 7, 2022
View reviewed changes
Copy link
Member
@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used by https://github.com/home-assistant/core/blob/dev/.github/workflows/builder.yml#L40-L49

@cdce8p cdce8p marked this pull request as draft February 7, 2022 16:51
@cdce8p cdce8p mentioned this pull request Feb 7, 2022
Merged
@cdce8p
Copy link
Member Author
cdce8p commented Feb 7, 2022

This file is used by https://github.com/home-assistant/core/blob/dev/.github/workflows/builder.yml#L40-L49

Opened home-assistant/actions#60 to fix the version actions.

@cdce8p cdce8p marked this pull request as ready for review February 10, 2022 13:18
@cdce8p cdce8p dismissed ludeeus’s stale review February 10, 2022 13:19

Action has been updated

@cdce8p
Copy link
Member Author
cdce8p commented Feb 10, 2022

The action has been updated and as far as I can tell, the nightly builds are successful.
@frenck This PR is be ready IMO. If you are more comfortable with waiting a bit longer, that would be fine for me too.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Feb 14, 2022
frenck
frenck approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

@frenck frenck merged commit 5c5f941 into home-assistant:dev Feb 21, 2022
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Feb 21, 2022
@cdce8p cdce8p deleted the remove-setup.py branch February 21, 2022 18:24
@frenck frenck mentioned this pull request Feb 22, 2022
Merged
22 tasks
@cdce8p cdce8p mentioned this pull request Feb 22, 2022
Merged
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@ludeeus ludeeus ludeeus left review comments

Assignees
No one assigned
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdce8p @frenck @ludeeus @homeassistant
0