bugfix [Zwave lock] Typo error and update test #6757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turbokongen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @devdelay, @balloob and @armills to be potential reviewers. |
|
Good catch. Should we leave the 'by' in |
|
My intention is that if you manually unlock/lock and the lock does not report a |
|
That makes sense. Works for me. |
turbokongen
referenced
this pull request
Mar 23, 2017
* ZWave Lock Tests * Linting fixes * Missed coveragerc
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update for a minor type noticed by @swbradshaw