8000 switch.tplink: upgrade to the newest upstream release which adds supp… by rytilahti · Pull Request #6790 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

switch.tplink: upgrade to the newest upstream release which adds supp… #6790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2017
Merged

switch.tplink: upgrade to the newest upstream release which adds supp… #6790

merged 1 commit into from
Mar 26, 2017

Conversation

rytilahti
Copy link
Member
@rytilahti rytilahti commented Mar 26, 2017 •
edited
Loading

…ort for plugs using the newer communication protocol

Description:

This updates the switch.tplink to depend on the newest release, which adds support for HS105 plugs.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2335

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@rytilahti
switch.tplink: upgrade to the newest upstream release which adds supp…
2609421 
…ort for plugs using the newer communication protocol
@mention-bot
Copy link

@rytilahti, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kirichkov, @scipioni and @fabaff to be potential reviewers.

This was referenced Mar 26, 2017
Merged
Closed
kirichkov
kirichkov approved these changes Mar 26, 2017
View reviewed changes
Copy link
Contributor
@kirichkov kirichkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I hope this makes it in 0.41.

fabaff
fabaff approved these changes Mar 26, 2017
View reviewed changes
Copy link
Member
@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit f5d4f85 into home-assistant:dev Mar 26, 2017
@rytilahti rytilahti deleted the update_pyhs100 branch March 29, 2017 20:59
@fabaff fabaff mentioned this pull request Apr 6, 2017
Merged
@rytilahti rytilahti restored the update_pyhs100 branch April 8, 2017 00:03
@balloob balloob mentioned this pull request Apr 8, 2017
Merged
8 tasks
@rytilahti rytilahti deleted the update_pyhs100 branch April 8, 2017 15:11
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

@kirichkov kirichkov kirichkov approved these changes

Assignees
No one assigned
Labels
platform requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rytilahti @mention-bot @fabaff @kirichkov @balloobbot @homeassistant
0