Add Bose soundtouch discovery support and upgrade libsoundtouch library #7005
Conversation
|
Hi @CharlesBlonde, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
@CharlesBlonde, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @rmkraus to be potential reviewers. |
|
Following your remark, I removed the global DEVICE variable... and it was a massive refactoring :) Besides, I updated media_player Edited: The Travis job failed but it has nothing to do with my work and since a few hours every jobs failed with the same Alexa tests so I think the error is somewhere else :) |
69c47ce to
875e31f
Compare
|
I just commit a small rewording and push force to trigger a new Travis build. |
|
|
||
| if discovery_info: | ||
| # Discovery | ||
| host = discovery_info[0] |
There was a problem hiding this comment.
Discovery info is a dictionary. Make sure your local dev environment has the latest netdisco (as required by the latest HASS)
There was a problem hiding this comment.
Ho S****, you are right. I should be using an old version in my Virtualenv because when I did my tests, it was a tuple and not a dictionary.
It should be better now.
It is shown in the service dev tool in the frontend. (and maybe one day in a config GUI) |
875e31f to
a1dd0bc
Compare
Description:
Update Bose Soundtouch component to:
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2401
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass