8000 Bugfix wait on start event by pvizeli · Pull Request #7013 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix wait on start event #7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2017
Merged

Bugfix wait on start event #7013

merged 5 commits into from
Apr 11, 2017

Conversation

pvizeli
Copy link
Member
@pvizeli pvizeli commented Apr 10, 2017 •
edited
Loading

Description:

This protect to track new task after we schedule all EVENT_HOMEASSISTANT_START listener task. Otherwise we can block forever there.

I remove also the assert on block_till_done while that is not needed. We support no task track in this function.

@mention-bot
Copy link
8000

@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @jaharkes to be potential reviewers.

@pvizeli pvizeli requested a review from balloob April 10, 2017 06:40
@pvizeli pvizeli added this to the 0.42.3 milestone Apr 10, 2017
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from 500de36 to d95b683 Compare April 10, 2017 08:36
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from 10cdfa2 to 0457237 Compare April 10, 2017 15:03
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from 3452b25 to 8fe968c Compare April 10, 2017 16:20
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from 708b70e to 8fe968c Compare April 10, 2017 16:57
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from 2481c03 to 6e30be1 Compare April 10, 2017 17:11
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from 9eedcc6 to c945ef0 Compare April 10, 2017 18:05
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from c945ef0 to 8fe968c Compare April 10, 2017 20:43
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from 7a2d8f6 to 981dfd5 Compare April 10, 2017 21:24
@pvizeli pvizeli force-pushed the fix_wait_on_start branch from 981dfd5 to 8fe968c Compare April 10, 2017 21:57
@pvizeli
Copy link
Member Author
pvizeli commented Apr 11, 2017 •
edited
Loading

@balloob for me is now okay. It is clean and nice solution. It is also a small cleanup

@pvizeli pvizeli force-pushed the 8000 fix_wait_on_start branch from 8124028 to 138ad41 Compare April 11, 2017 12:41
@balloob balloob merged commit b52cabf into home-assistant:dev Apr 11, 2017
balloob pushed a commit that referenced this pull request Apr 11, 2017
@pvizeli @balloob
Bugfix wait on start event (#7013)
7377ce2 
* Bugfix wait on start event

* Paulus sugestion

* Change handling with stop_track_task

* Add new unittests

* Update test_core.py
@balloob balloob mentioned this pull request Apr 11, 2017
Merged
@balloob
Copy link
Member
balloob commented Apr 11, 2017

Cherry picked for 0.42.3

@jimbob1001 jimbob1001 mentioned this pull request Apr 11, 2017
Closed
@balloob balloob mentioned this pull request Apr 21, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob Awaiting requested review from balloob

Assignees
No one assigned
Labels
cla-signed core
Projects
None yet
Milestone
0.42.3
Development

Successfully merging this pull request may close these issues.
5 participants
@pvizeli @mention-bot @balloob @balloobbot @homeassistant
0