Update ios.py #7160
Merged
Update ios.py #7160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as discussed. the part:
if battery_state == ios.ATTR_BATTERY_STATE_FULL:
returning_icon_level = DEFAULT_ICON_LEVEL
kinda screws up the charging icon.
i might just miss a logical solution for that though.
let me know what you think. it might not be beautiful but i think its an overall improve over the current "double battery" solution
|
@biacz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @robbiet480 and @kellerza to be potential reviewers. |
houndci-bot
reviewed
Apr 18, 2017
|
|
||
| def update(self): | ||
| """Get the latest state of the sensor.""" | ||
| self._device = ios.devices().get(self._device_name) | ||
| self._state = self._device[ios.ATTR_BATTERY][self.type] | ||
|
|
There was a problem hiding this comment.
blank line at end of file
blank line contains whitespace
| else: | ||
| returning_icon = "{}-{}".format(DEFAULT_ICON, | ||
| str(rounded_level)) | ||
| returning_icon_level = "{}-{}".format(DEFAULT_ICON_LEVEL,str(rounded_level)) |
There was a problem hiding this comment.
missing whitespace after ','
line too long (92 > 79 characters)
| elif battery_state == ios.ATTR_BATTERY_STATE_CHARGING: | ||
| # Why is MDI missing 10, 50, 70? | ||
| if rounded_level in (20, 30, 40, 60, 80, 90, 100): | ||
| returning_icon = "{}-charging-{}".format(DEFAULT_ICON, | ||
| str(rounded_level)) | ||
| returning_icon_level = "{}-charging-{}".format(DEFAULT_ICON_LEVEL,str(rounded_level)) |
There was a problem hiding this comment.
line too long (101 > 79 characters)
missing whitespace after ','
chound fix and full_battery_charge fix
houndci-bot
reviewed
Apr 18, 2017
| else: | ||
| returning_icon = "{}-{}".format(DEFAULT_ICON, | ||
| str(rounded_level)) | ||
| returning_icon_level = "{}-{}".format(DEFAULT_ICON_LEVEL, |
| returning_icon = "{}-charging-{}".format(DEFAULT_ICON, | ||
| str(rounded_level)) | ||
| returning_icon_level = "{}-charging-{}".format(DEFAULT_ICON_LEVEL, | ||
| str(rounded_level)) |
There was a problem hiding this comment.
line too long (82 > 79 characters)
| elif battery_state == ios.ATTR_BATTERY_STATE_CHARGING: | ||
| # Why is MDI missing 10, 50, 70? | ||
| if rounded_level in (20, 30, 40, 60, 80, 90, 100): | ||
| returning_icon = "{}-charging-{}".format(DEFAULT_ICON, | ||
| str(rounded_level)) | ||
| returning_icon_level = "{}-charging-{}".format(DEFAULT_ICON_LEVEL, |
There was a problem hiding this comment.
line too long (82 > 79 characters)
trailing whitespace
removed new line
houndci-bot
reviewed
Apr 18, 2017
|
|
||
| def update(self): | ||
| """Get the latest state of the sensor.""" | ||
| self._device = ios.devices().get(self._device_name) | ||
| self._state = self._device[ios.ATTR_BATTERY][self.type] | ||
| self._state = self._device[ios.ATTR_BATTERY][self.type] |
houndci-bot
reviewed
Apr 18, 2017
| elif battery_state == ios.ATTR_BATTERY_STATE_UNPLUGGED: | ||
| if rounded_level < 10: | ||
| returning_icon = "{}-outline".format(DEFAULT_ICON) | ||
| returning_icon_level = |
| else: | ||
| returning_icon = "{}-charging".format(DEFAULT_ICON) | ||
| returning_icon_level = |
| returning_icon = "{}-charging-{}".format(DEFAULT_ICON, | ||
| str(rounded_level)) | ||
| returning_icon_level = | ||
| "{}-charging-{}".format(DEFAULT_ICON_LEVEL, |
| elif battery_state == ios.ATTR_BATTERY_STATE_CHARGING: | ||
| # Why is MDI missing 10, 50, 70? | ||
| if rounded_level in (20, 30, 40, 60, 80, 90, 100): | ||
| returning_icon = "{}-charging-{}".format(DEFAULT_ICON, | ||
| str(rounded_level)) | ||
| returning_icon_level = |
There was a problem hiding this comment.
trailing whitespace
SyntaxError: invalid syntax
|
i hope thats it - thanks @robbiet480 and @kellerza for resolving any additional things. thanks guys. |
robbiet480
requested changes
Apr 20, 2017
| elif battery_level == 100: | ||
| returning_icon_state = "{}-off".format(DEFAULT_ICON_STATE) | ||
| returning_icon_level = "{}-outline".format( | ||
| DEFAULT_ICON_LEVEL) | ||
| elif battery_level > 95: |
There was a problem hiding this comment.
Combine this and the elif battery_level == 100 chain?
houndci-bot
reviewed
Apr 20, 2017
| DEFAULT_ICON_LEVEL) | ||
| returning_icon_state = "{}-off".format(DEFAULT_ICON_STATE) | ||
| elif battery_level > 95 | ||
| returning_icon_state = "{}-off".format(DEFAULT_ICON_STATE) |
| returning_icon_level = "{}-outline".format( | ||
| DEFAULT_ICON_LEVEL) | ||
| returning_icon_state = "{}-off".format(DEFAULT_ICON_STATE) | ||
| elif battery_level > 95 |
houndci-bot
reviewed
Apr 20, 2017
| else: | ||
| returning_icon = "{}-{}".format(DEFAULT_ICON, | ||
| str(rounded_level)) | ||
| returning_icon_level = "{}-{}".format(DEFAULT_ICON_LEVEL, |
robbiet480
approved these changes
Apr 21, 2017
|
Cherry-picked for 0.43 |
balloob
pushed a commit
that referenced
this pull request
Apr 22, 2017
* Update ios.py
as discussed. the part:
if battery_state == ios.ATTR_BATTERY_STATE_FULL:
returning_icon_level = DEFAULT_ICON_LEVEL
kinda screws up the charging icon.
i might just miss a logical solution for that though.
let me know what you think. it might not be beautiful but i think its an overall improve over the current "double battery" solution
* Update ios.py
chound fix and full_battery_charge fix
* Update ios.py
removed new line
* Update ios.py
* Update ios.py
* Update ios.py
* Update ios.py
* Update ios.py
* Update ios.py
* merged request from robbie
* Update ios.py
* Update ios.py
* Update ios.py
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed. the part:
if battery_state == ios.ATTR_BATTERY_STATE_FULL:
returning_icon_level = DEFAULT_ICON_LEVEL
kinda screws up the charging icon.
i might just miss a logical solution for that though.
let me know what you think. it might not be beautiful but i think its an overall improve over the current "double battery" solution
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass