8000 Warn user if "model" key is missing from Shelly firmware by chemelli74 · Pull Request #71612 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Warn user if "model" key is missing from Shelly firmware #71612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 18, 2022
Merged

Warn user if "model" key is missing from Shelly firmware #71612

merged 8 commits into from
May 18, 2022

Conversation

chemelli74
Copy link
Contributor

Proposed change

If the key "model" is missing, means that the firmware was not fully provisioned by the vendor.
The correct and only solution is contact their support.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @balloob, @bieniu, @thecode, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

thecode
thecode reviewed May 9, 2022
View reviewed changes
@thecode thecode added this to the 2022.5.4 milestone May 9, 2022
@chemelli74 chemelli74 requested a review from thecode May 11, 2022 16:59
@chemelli74 chemelli74 changed the title Warn using if "model" key is missing from Shelly firmware Warn user if "model" key is missing from Shelly firmware May 11, 2022
thecode
thecode requested changes May 12, 2022
View reviewed changes
Copy link
Member
@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing this PR I found out that we don't cover the following:

  • Zeroconf discovery
  • Device has authentication enabled

balloob
balloob reviewed May 12, 2022
View reviewed changes
@balloob
Copy link
Member
balloob commented May 12, 2022

Just saw the comment from @thecode, those still need addressing.

@thecode thecode modified the milestones: 2022.5.4, 2022.5.5 May 13, 2022
@chemelli74 chemelli74 requested a review from thecode May 15, 2022 16:56
thecode
thecode reviewed May 16, 2022
View reviewed changes
Copy link
Member
@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are good, need to complete tests

@balloob balloob merged commit 4a95539 into home-assistant:dev May 18, 2022
balloob added a commit that referenced this pull request May 18, 2022
@chemelli74 @balloob
Warn user if "model" key is missing from Shelly firmware (#71612)
a3bd911 
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@balloob balloob mentioned this pull request May 18, 2022
Merged
@chemelli74 chemelli74 deleted the chemelli74-model-warning branch May 18, 2022 21:54
@thecode thecode mentioned this pull request May 18, 2022
Merged
22 tasks
0bmay pushed a commit to 0bmay/home-assistant-core that referenced this pull request May 19, 2022
@chemelli74 @balloob @0bmay
Warn user if "model" key is missing from Shelly firmware (home-assist…
0403ecd 
…ant#71612)

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thecode thecode thecode requested changes

@balloob balloob balloob approved these changes

@bieniu bieniu Awaiting requested review from bieniu bieniu is a code owner

Assignees

@bieniu bieniu

@balloob balloob

@thecode thecode

Labels
bugfix by-code-owner cherry-picked cla-signed integration: shelly small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.5.5
Development

Successfully merging this pull request may close these issues.

Manual Shelly integration via IP failing
5 participants
@chemelli74 @balloob @thecode @bieniu @homeassistant
0