8000 Add HassIO to discovery component by pvizeli · Pull Request #7195 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add HassIO to discovery component #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 21, 2017
Merged

Conversation

pvizeli
Copy link
Member
@pvizeli pvizeli commented Apr 20, 2017

Description:

Allow discovery component to discovery HassIO

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@pvizeli pvizeli added this to the 0.43 milestone Apr 20, 2017
@pvizeli pvizeli requested a review from balloob April 20, 2017 15:44
@mention-bot
Copy link

@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @postlund and @fabaff to be potential reviewers.

@asyncio.coroutine
def test_load_component_hassio(hass):
"""Test load hassio component."""
os.environ['HASSIO'] = "FAKE_HASSIO"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use patch.dict so that this test doesn't have side effects: https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch.dict

@balloob balloob merged commit f641287 into home-assistant:dev Apr 21, 2017
@balloob balloob mentioned this pull request Apr 21, 2017
@balloob balloob removed this from the 0.43 milestone Apr 21, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0