8000 Revert changing `pysnmp` to `pysnmplib` by bieniu · Pull Request #71901 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert changing pysnmp to pysnmplib #71901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2022
Merged

Revert changing pysnmp to pysnmplib #71901

merged 1 commit into from
May 15, 2022

Conversation

bieniu
Copy link
Member
@bieniu bieniu commented May 15, 2022 •
edited
Loading

Breaking change

Proposed change

It turned out that the pysnmplib library has a bug that harm snmp integration users. PR with the fix is waiting for a week without reaction of maintainer and there is a chance that this fork is also dead.

This PR reverts changing pysnmp to pysnmp library from #69841

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes SNMP Sensor #71368
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bieniu bieniu added this to the 2022.5.5 milestone May 15, 2022
@frenck
Copy link
Member
frenck commented May 15, 2022

Could you add some context to the PR description?

@bieniu
Copy link
Member Author
bieniu commented May 15, 2022

Could you add some context to the PR description?

Description added.

@bdraco
Copy link
Member
bdraco commented May 15, 2022

Thanks @bieniu

frenck
frenck approved these changes May 15, 2022
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bieniu 👍

@frenck frenck merged commit 904be03 into home-assistant:dev May 15, 2022
@bieniu bieniu deleted the pysnmp-revert branch May 15, 2022 18:38
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@bdraco bdraco bdraco approved these changes

@thecode thecode thecode approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed dependency dependency-bump integration: brother integration: snmp small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.5.5
Development

Successfully merging this pull request may close these issues.

SNMP Sensor
6 participants
@bieniu @frenck @bdraco @thecode @balloob @homeassistant
0