8000 Ignore UpnpXmlContentError in SamsungTV by epenet · Pull Request #72056 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ignore UpnpXmlContentError in SamsungTV #72056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2022
Merged

Ignore UpnpXmlContentError in SamsungTV #72056

merged 2 commits into from
May 18, 2022

Conversation

epenet
Copy link
Contributor
@epenet epenet commented May 18, 2022 •
edited
Loading

Proposed change

Fixes an issue when the SamsungTV returns invalid Upnp information.

2022-05-17 14:01:04 ERROR (MainThread) [homeassistant.helpers.entity] Update for media_player.samsung_tv fails
Traceback (most recent call last):
  File "/opt/homeassistant/venv_3.9/lib/python3.9/site-packages/homeassistant/helpers/entity.py", line 515, in async_update_ha_state
    await self.async_device_update()
  File "/opt/homeassistant/venv_3.9/lib/python3.9/site-packages/homeassistant/helpers/entity.py", line 743, in async_device_update
    raise exc
  File "/opt/homeassistant/venv_3.9/lib/python3.9/site-packages/homeassistant/components/samsungtv/media_player.py", line 222, in async_update
    await asyncio.gather(*startup_tasks)
  File "/opt/homeassistant/venv_3.9/lib/python3.9/site-packages/homeassistant/components/samsungtv/media_player.py", line 274, in _async_startup_dmr
    upnp_device = await upnp_factory.async_create_device(
  File "/opt/homeassistant/venv_3.9/lib/python3.9/site-packages/async_upnp_client/client_factory.py", line 77, in async_create_device
    raise UpnpXmlContentError("Could not find device element")
async_upnp_client.exceptions.UpnpXmlContentError: ('Could not find device element', None)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet epenet requested a review from chemelli74 as a code owner May 18, 2022 06:04
@probot-home-assistant
Copy link

Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet added this to the 2022.5.5 milestone May 18, 2022
@epenet
Copy link
Contributor Author
epenet commented May 18, 2022

cc @bdraco

bdraco
bdraco approved these changes May 18, 2022
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bdraco
bdraco reviewed May 18, 2022
View reviewed changes
homeassistant/components/samsungtv/media_player.py Outdated
upnp_device = await upnp_factory.async_create_device(
self._ssdp_rendering_control_location
)
if not upnp_device:
except (UpnpConnectionError, UpnpResponseError, UpnpXmlContentError) as err:
LOGGER.debug("Unable to create Upnp DMR device: %r", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could set exc_info here if you want to look the full trace

@epenet epenet mentioned this pull request May 18, 2022
Closed
@frenck frenck merged commit 8d57f70 into home-assistant:dev May 18, 2022
@epenet epenet deleted the samsungtv-upnpxmlcontenterror branch May 18, 2022 07:37
@epenet epenet mentioned this pull request May 18, 2022
Merged
22 tasks
balloob pushed a commit that referenced this pull request May 18, 2022
@epenet @balloob
Ignore UpnpXmlContentError in SamsungTV (#72056)
a1df9c3
@balloob balloob mentioned this pull request May 18, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@bdraco bdraco bdraco approved these changes

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 is a code owner

Assignees

@chemelli74 chemelli74

Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: samsungtv small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.5.5
Development

Successfully merging this pull request may close these issues.
6 participants
@epenet @frenck @bdraco @balloob @homeassistant @chemelli74
0