8000 tradfri: Improve color temp support detection by balloob · Pull Request #7211 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tradfri: Improve color temp support detection #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2017
Merged

Conversation

balloob
Copy link
Member
@balloob balloob commented Apr 22, 2017

Description:

We would print errors for Tradfri bulbs without color temperature. This PR fixes it. Also synced up the Dockerfile.dev with the main Dockerfile.

Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed. Another thing I thought about, now we return rgb color in the corresponding property also when only supporting color temperature. So rgb color will show in state attributes, even though not supported to change right?

self._features &= SUPPORT_COLOR_TEMP
else:
self._features &= SUPPORT_RGB_COLOR

self._ok_temps = ALLOWED_TEMPERATURES.get(
slugify(self._light.device_info.manufacturer))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove use of slugify, since you changed IKEA.

@MartinHjelmare MartinHjelmare mentioned this pull request Apr 22, 2017
1 task
@balloob balloob mentioned this pull request May 5, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0