8000 Use `pysnmplib` instead of `pysnmp` by bieniu · Pull Request #72645 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use pysnmplib instead of pysnmp #72645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2022
Merged

Use pysnmplib instead of pysnmp #72645

merged 3 commits into from
May 30, 2022

Conversation

bieniu
Copy link
Member
@bieniu bieniu commented May 28, 2022

Breaking change

Proposed change

snmp and brother integrations use pysnmp package, which has not been developed in a long time and has a bug preventing it from working with Python 3.10. There is a community fork for this package and the bug has been fixed.

This is a second attempt to migrate from pysnmp to pysnmplib for snmp integration and upgrade the version of the brother package which also uses pysnmplib.

I tested the new version of pysnmplib with 10 snmp sensors for a few hours without errors so I think there shouldn't be supprises like this #71368.

pysnmplib changelog: pysnmp/pysnmp@v4.4.12...v5.0.15
brother changelog: bieniu/brother@1.1.0...1.2.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

8000 Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 75669db into home-assistant:dev May 30, 2022
@bdraco
Copy link
Member
bdraco commented May 30, 2022

Tested. Working as expected 👍

@bieniu bieniu deleted the pysnmplib branch May 30, 2022 17:39
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0