8000 Add base Entity to pylint checks by epenet · Pull Request #73902 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

A 8000 dd base Entity to pylint checks #73902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2022
Merged

Add base Entity to pylint checks #73902

merged 6 commits into from
Jun 27, 2022

Conversation

epenet
Copy link
Contributor
@epenet epenet commented Jun 23, 2022 •
edited
Loading

Proposed change

Linked to #73901

Marked as draft until #73886 is merged to avoid conflicts

pylint --disable=all --enable=hass_enforce_type_hints --ignore-missing-annotations=n homeassistant/components/

************* Module homeassistant.components.wilight.fan
homeassistant/components/wilight/fan.py:64:4: W7432: Return type should be ['str', None] (hass-return-type)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet epenet mentioned this pull request Jun 23, 2022
Merged
22 tasks
@epenet epenet requested a review from cdce8p June 23, 2022 12:51
@epenet epenet force-pushed the pylint-add-base-entity branch from 285238a to e362167 Compare June 23, 2022 14:59
@epenet epenet force-pushed the pylint-add-base-entity branch from e362167 to 546373a Compare June 24, 2022 04:42
@epenet epenet marked this pull request as ready for review June 24, 2022 04:43
cdce8p
cdce8p reviewed Jun 25, 2022
View reviewed changes
@epenet epenet merged commit b185de0 into home-assistant:dev Jun 27, 2022
@epenet epenet deleted the pylint-add-base-entity branch June 27, 2022 10:10
@epenet epenet mentioned this pull request Jun 27, 2022
Merged
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epenet @cdce8p @homeassistant
0