8000 List more private and link-local IP networks by pyos · Pull Request #74064 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

List more private and link-local 8000 IP networks #74064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

List more private and link-local IP networks #74064

merged 1 commit into from
Jun 28, 2022

Conversation

pyos
Copy link
Contributor
@pyos pyos commented Jun 27, 2022 •
edited
Loading

Proposed change

The list of private networks was missing IPv4 ones mapped to IPv6, and no IPv6 addresses were recognized as link-local. This made local-only accounts unusable on IPv6-capable networks with no IPv6 DHCP server.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@pyos pyos requested review from bdraco, Kane610 and a team as code owners June 27, 2022 18:08
@probot-home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (dhcp) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (axis) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @oblogic7, @bdraco, @flacjacket, mind taking a look at this pull request as it has been labeled with an integration (doorbird) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

bdraco
bdraco approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes

@pyos pyos force-pushed the remove-ip-ranges branch from f341e6a to fd9d928 Compare June 27, 2022 18:31
@pyos
Copy link
Contributor Author
pyos commented Jun 27, 2022

@bdraco could you restart the CI please? I forgot to remove an unused import

@bdraco
Copy link
Member
bdraco commented Jun 27, 2022

@bdraco could you restart the CI please? I forgot to remove an unused import

Done

bdraco
bdraco requested changes Jun 27, 2022
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pyos Looks like there are still a few places that need adjustments

@epenet
Copy link
Contributor
epenet commented Jun 27, 2022

Should the methods be deprecated instead of removed right away?
Custom components might be impacted.

@bdraco
Copy link
Member
bdraco commented Jun 27, 2022

Should the methods be deprecated instead of removed right away?

Custom components might be impacted.

That's a good point, we should probably leave them in place and have them throw warnings when used

@pyos pyos force-pushed the remove-ip-ranges branch 3 times, most recently from 4ce1577 to 37953bd Compare June 27, 2022 21:18
@pyos pyos changed the title Remove IP ranges from homeassistant.util.network List more private and link-local IP networks Jun 27, 2022
@pyos
Copy link
Contributor Author
pyos commented Jun 27, 2022 •
edited
Loading

Never mind that part, I assumed ipaddress is bug-free, but it is not; it does not consider IPv4-mapped IPv6 addresses at all. (Also "private" in ipaddress terminology means "reserved" while in homeassistant.util.network it's more like "unique local".)

@pyos
List more private and link-local IP networks
6ee164c 
The IPv6 link-local network is especially important as without it
local accounts don't work on IPv6-capable networks with no IPv6 DHCP
server.
@pyos pyos force-pushed the remove-ip-ranges branch from 37953bd to 6ee164c Compare June 27, 2022 21:34
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Jun 28, 2022
@balloob balloob merged commit 91a1199 into home-assistant:dev Jun 28, 2022
elupus
elupus reviewed Jun 28, 2022
View reviewed changes
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elupus elupus elupus left review comments

@bdraco bdraco bdraco approved these changes

@Kane610 Kane610 Awaiting requested review from Kane610

Assignees

@bdraco bdraco

@Kane610 Kane610

Labels
bugfix cla-signed core integration: axis integration: dhcp integration: doorbird small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
42DE
Development

Successfully merging this pull request may close these issues.
7 participants
@pyos @bdraco @epenet @elupus @balloob @homeassistant @Kane610
0