8000 Adjust config-flow reauth type hints in components by epenet · Pull Request #74088 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adjust con 8000 fig-flow reauth type hints in components #74088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

Adjust config-flow reauth type hints in components #74088

merged 1 commit into from
Jun 28, 2022

Conversation

epenet
Copy link
Contributor
@epenet epenet commented Jun 28, 2022

Proposed change

Linked to #72830

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (google) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @dshokouhi, @Santobert, mind taking a look at this pull request as it has been labeled with an integration (neato) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (spotify) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @matrixd2, mind taking a look at this pull request as it has been labeled with an integration (yolink) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration (netatmo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet mentioned this pull request Jun 28, 2022
Merged
29 tasks
Kane610
Kane610 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member
@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good!

@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Jun 28, 2022
frenck
frenck approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@frenck frenck merged commit b6676df into home-assistant:dev Jun 28, 2022
@epenet epenet deleted the reauth-components branch June 28, 2022 06:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@Kane610 Kane610 Kane610 approved these changes

@cgtobi cgtobi Awaiting requested review from cgtobi cgtobi is a code owner

@Santobert Santobert Awaiting requested review from Santobert

@allenporter allenporter Awaiting requested review from allenporter allenporter is a code owner

Assignees

@frenck frenck

@cgtobi cgtobi

@dshokouhi dshokouhi

@allenporter allenporter

@Santobert Santobert

Labels
cla-signed code-quality integration: google integration: neato integration: netatmo integration: spotify integration: yolink small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@epenet @frenck @Kane610 @cgtobi @dshokouhi @allenporter @Santobert @homeassistant
0