8000 Switchbot bump Dependency 0.14.0 by RenierM26 · Pull Request #74001 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switchbot bump Dependency 0.14.0 #74001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 27, 2022
Merged

Switchbot bump Dependency 0.14.0 #74001

merged 9 commits into from
Jun 27, 2022

Conversation

RenierM26
Copy link
Contributor

Proposed change

Bump switchbot dependency, now makes use of full async bleak library.

Full Changelog: sblibs/pySwitchbot@0.13.3...0.14.0
Release notes: https://github.com/Danielhiversen/pySwitchbot/releases

The dependency update improves reliability of switchbot devices.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
probot-home-assistant bot 8000 commented Jun 26, 2022

Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

MartinHjelmare
MartinHjelmare reviewed Jun 26, 2022
View reviewed changes
MartinHjelmare
8000
MartinHjelmare approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

MartinHjelmare
MartinHjelmare requested changes Jun 26, 2022
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the line from gen_requirements_all.py.

This was referenced Jun 26, 2022
Closed
Closed
MartinHjelmare
MartinHjelmare approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RenierM26 RenierM26 mentioned this pull request Jun 26, 2022
Closed
@pvizeli pvizeli merged commit 10ea88e into home-assistant:dev Jun 27, 2022
@RenierM26 RenierM26 deleted the switchbot_bump_dep_0.14.0 branch June 27, 2022 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

Assignees

@Danielhiversen Danielhiversen

Labels
by-code-owner cla-signed dependency has-tests integration: switchbot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RenierM26 @MartinHjelmare @Danielhiversen @pvizeli @homeassistant
0