8000 Visiblity fix unit km to m by leroyloren · Pull Request #74008 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Visiblity fix unit km to m #74008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2022
Merged

Visiblity fix unit km to m #74008

merged 2 commits into from
Jun 27, 2022

Conversation

leroyloren
Copy link

Fix unit
#73914

API doc
https://openweathermap.org/current#:~:text=ground%20level%2C%20hPa-,visibility,-Visibility%2C%20meter.%20The
visibility Visibility, meter. The maximum value of the visibility is 10km

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@leroyloren leroyloren requested a review from fabaff as a code owner June 26, 2022 12:29
@homeassistant
Copy link
Contributor

Hi @leroyloren,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @fabaff, @freekode, @nzapponi, mind taking a look at this pull request as it has been labeled with an integration (openweathermap) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added smash Indicator this PR is close to finish for merging or closing and removed smash Indicator this PR is close to finish for merging or closing labels Jun 26, 2022
frenck
frenck 8000 requested changes Jun 26, 2022
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leroyloren The CI is failing. Make sure you test your code changes before actually opening a PR.

Could you check what is going on? Thanks! 👍

@leroyloren leroyloren requested a review from frenck June 26, 2022 12:45
@leroyloren
Copy link
Author

@frenck Sry, check it again please.

@leroyloren leroyloren changed the title Visiblity fix unit km => m Visiblity fix unit km to m Jun 26, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 27, 2022
frenck
frenck approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @leroyloren 👍

@frenck frenck merged commit e706c6a into home-assistant:dev Jun 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@fabaff fabaff Awaiting requested review from fabaff fabaff is a code owner

Assignees

@fabaff fabaff

Labels
bugfix cla-signed integration: openweathermap small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leroyloren @homeassistant @frenck @fabaff
0