8000 Bump deconz dependency to fix #74523 by Kane610 · Pull Request #74710 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump deconz dependency to fix #74523 #74710 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

Bump deconz dependency to fix #74523 #74710

merged 1 commit into from
Jul 8, 2022

Conversation

Kane610
Copy link
Member
@Kane610 Kane610 commented Jul 8, 2022

Breaking change

Proposed change

hasattr for some reason performs the call of air_quality_ppb so it failed because the method expects the dictionary key to exist.
Kane610/deconz@v96...v97
Non-functional changes, I've saved all PRs breaking compatibility just in case, lucky! :)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2022.7.2 milestone Jul 8, 2022
@Kane610
Copy link
Member Author
Kane610 commented Jul 8, 2022

Thank you @pvizeli 🎉

@pvizeli pvizeli merged commit 3b3766f into home-assistant:dev Jul 8, 2022
@Kane610 Kane610 deleted the deconz-bump_pydeconz_to_v97 branch July 8, 2022 11:34
balloob pushed a commit that referenced this pull request Jul 8, 2022
@Kane610 @balloob
Bump deconz dependency to fix #74523 (#74710)
e80fd4f
@balloob balloob mentioned this pull request Jul 8, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: deconz small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.7.2
Development

Successfully merging this pull request may close these issues.

deCONZ Integration fails to set up with IKEA STARKVIND device paired to network
4 participants
@Kane610 @pvizeli @balloob @homeassistant
0