tellduslive: Fix exception when starting #7618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
requested changes
May 17, 2017
| @@ -56,7 +57,8 @@ def setup(hass, config): | |||
| return False | |||
|
|
|||
| hass.data[DOMAIN] = client | |||
| client.update(utcnow()) | |||
|
|
|||
| hass.bus.listen(EVENT_HOMEASSISTANT_START, client.update) | |||
There was a problem hiding this comment.
Instead of this, move self._client.entities.append(self) from TelldusEntity __init__ to a new method on that class:
@asyncio.coroutine
def async_added_to_hass(self):
"""Entity has been added to hass."""
self._client.entities.append(self)When async_added_to_hass gets called, hass is set so updating the client will not result in entities without hass
There was a problem hiding this comment.
Ok, but with this change, the periodically polling of the server never starts, since update() reschedules itself after each run of sync. Should I make your change, in addition to keeping the hass.bus.listen-stuff?
There was a problem hiding this comment.
Good point. Keep the start listener and start polling on START event. Append in added_to_hass hook
balloob
approved these changes
Jun 2, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #7019
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass